Skip to content

Revert "[SPARK-29629][SQL] Support typed integer literal expression"#26940

Closed
gengliangwang wants to merge 1 commit into
apache:masterfrom
gengliangwang:revert_Spark_29629
Closed

Revert "[SPARK-29629][SQL] Support typed integer literal expression"#26940
gengliangwang wants to merge 1 commit into
apache:masterfrom
gengliangwang:revert_Spark_29629

Conversation

@gengliangwang

Copy link
Copy Markdown
Member

This reverts commit 8e667db.

@gengliangwang

gengliangwang commented Dec 19, 2019

Copy link
Copy Markdown
Member Author

In PostgreSQL, all the data types in https://www.postgresql.org/docs/9.1/datatype-numeric.html are supported to create such literals. E.g. smallint '1', float '2.3'
It is odd to support 'integer' only in Spark.
Now we don't care too much about Postgrel compatibility, so I suppose we are not going to add full support for all numeric type literals in this form.

@gengliangwang

Copy link
Copy Markdown
Member Author

@yaooqinn

Copy link
Copy Markdown
Member

+1, LGTM

@maropu

maropu commented Dec 19, 2019

Copy link
Copy Markdown
Member

Looks fine to me, too.

@SparkQA

SparkQA commented Dec 19, 2019

Copy link
Copy Markdown

Test build #115531 has finished for PR 26940 at commit 82a33b2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HyukjinKwon

Copy link
Copy Markdown
Member

Merged to master.

@xuanyuanking

Copy link
Copy Markdown
Member

Linked this with SPARK-30125 as well as #26763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants